Skip to content

fix(material/core): define token overrides inline #30646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(material/core): define token overrides inline #30646

wants to merge 1 commit into from

Conversation

andrewseguin
Copy link
Contributor

Creates CSS variables for the overrides API inline instead of using a new selector rule for each token

html {
  @include mat.checkbox-overrides(
    (
      disabled-label-color: orange,
      label-text-color: red,
    )
  );
}

Before:

html {
  --mat-checkbox-disabled-label-color: orange;
}
html {
  --mat-checkbox-label-text-color: red;
}

After:

html {
  --mat-checkbox-disabled-label-color: orange;
  --mat-checkbox-label-text-color: red;
}

@andrewseguin andrewseguin requested a review from a team as a code owner March 18, 2025 15:53
@andrewseguin andrewseguin requested review from crisbeto and wagnermaciel and removed request for a team March 18, 2025 15:53
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba approved these changes

@crisbeto crisbeto Awaiting requested review from crisbeto crisbeto is a code owner automatically assigned from angular/components-googlers

@wagnermaciel wagnermaciel Awaiting requested review from wagnermaciel wagnermaciel is a code owner automatically assigned from angular/components-googlers

Assignees
No one assigned
Labels
area: material/core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewseguin @mmalerba